Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate --cache and home with cask #7789

Merged
merged 19 commits into from
Jun 24, 2020
Merged

Integrate --cache and home with cask #7789

merged 19 commits into from
Jun 24, 2020

Conversation

whoiswillma
Copy link
Contributor

@whoiswillma whoiswillma commented Jun 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add the ability to reference casks from brew --cache and brew home.

brew --cache <cask> prints the cask's cached without any prefix.

brew home <cask> opens the homepage of the cask in the default browser.

With respect to the tests, I don't think I should reference a cask that exists as part of homebrew-casks, yet I cannot figure out how to add a cask such that it can be referenced by name from Cask::CaskLoader.load. I currently pass in the path to the local-caffeine cask. I'm relatively new to Ruby, so I'm not sure of all the factors in play here, but it appears tests/cask/cask_spec.rb:32 is able to reference local-caffeine without trouble, and I'm interested to learn why.

@request-info
Copy link

request-info bot commented Jun 22, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jun 22, 2020
@MikeMcQuaid
Copy link
Member

@whoiswillma when you're ready for this: please reopen and just update the title/description rather than creating a new PR. Thanks!

@whoiswillma whoiswillma changed the title Cask integration Integrate --cache and home with cask Jun 22, 2020
@whoiswillma whoiswillma reopened this Jun 22, 2020
@whoiswillma whoiswillma requested a review from reitermarkus June 23, 2020 14:34
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me so far! I'll check it out locally and play around with it tomorrow. Nice work everyone!

@MikeMcQuaid MikeMcQuaid dismissed EricFromCanada’s stale review June 24, 2020 08:02

Comments addressed

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @whoiswillma!

@MikeMcQuaid MikeMcQuaid merged commit 1dbbb5e into Homebrew:master Jun 24, 2020
@whoiswillma whoiswillma deleted the cask-integration branch July 6, 2020 22:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs response Needs a response from the issue/PR author outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants