-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate --cache
and home
with cask
#7789
Integrate --cache
and home
with cask
#7789
Conversation
Please provide a better issue/pull request title and/or description! |
@whoiswillma when you're ready for this: please reopen and just update the title/description rather than creating a new PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me so far! I'll check it out locally and play around with it tomorrow. Nice work everyone!
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @whoiswillma! |
brew style
with your changes locally?brew tests
with your changes locally?Add the ability to reference casks from
brew --cache
andbrew home
.brew --cache <cask>
prints the cask's cached without any prefix.brew home <cask>
opens the homepage of the cask in the default browser.With respect to the tests, I don't think I should reference a cask that exists as part of
homebrew-casks
, yet I cannot figure out how to add a cask such that it can be referenced by name fromCask::CaskLoader.load
. I currently pass in the path to thelocal-caffeine
cask. I'm relatively new to Ruby, so I'm not sure of all the factors in play here, but it appearstests/cask/cask_spec.rb:32
is able to referencelocal-caffeine
without trouble, and I'm interested to learn why.